Kontinuation commented on PR #306:
URL: https://github.com/apache/sedona-db/pull/306#issuecomment-3532796818
For calling non-generic functions in the same crate, adding `#[inline]` or
not does not matter too much, since LLVM inlines code aggressively. For calling
non-generic functions in other crates and LTO is not enabled, adding
`#[inline]` will enable cross-crate inline for annotated functions; adding
`#[inline]` or not will result in a measurable performance difference in this
case. Here is the benchmark result I got before adding `#[inline]`:
```
native-rs_width-Array(Raster(64, 64))
time: [1.2776 ms 1.2867 ms 1.3022 ms]
change: [-82.709% -82.587% -82.409%] (p = 0.00 <
0.05)
Performance has improved.
Found 14 outliers among 100 measurements (14.00%)
6 (6.00%) high mild
8 (8.00%) high severe
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
