Copilot commented on code in PR #307: URL: https://github.com/apache/sedona-db/pull/307#discussion_r2528322911
########## rust/sedona-raster-functions/src/rs_example.rs: ########## @@ -0,0 +1,153 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. +use std::{sync::Arc, vec}; + +use crate::executor::RasterExecutor; +use datafusion_common::error::Result; +use datafusion_expr::{ + scalar_doc_sections::DOC_SECTION_OTHER, ColumnarValue, Documentation, Volatility, +}; +use sedona_expr::scalar_udf::{SedonaScalarKernel, SedonaScalarUDF}; +use sedona_raster::builder::RasterBuilder; +use sedona_raster::traits::BandMetadata; +use sedona_raster::traits::RasterMetadata; +use sedona_schema::{ + crs::lnglat, + datatypes::SedonaType, + matchers::ArgMatcher, + raster::{BandDataType, StorageType}, +}; + +/// RS_Example() scalar UDF implementation +/// +/// Creates a simple concrete example for testing purposes +/// May expand with additional optional parameters in the future +pub fn rs_example_udf() -> SedonaScalarUDF { + SedonaScalarUDF::new( + "rs_example", + vec![Arc::new(RsExample {})], + Volatility::Immutable, + Some(rs_example_doc()), + ) +} + +fn rs_example_doc() -> Documentation { + Documentation::builder( + DOC_SECTION_OTHER, + "Return an example raster".to_string(), + "RS_Example()".to_string(), + ) + .with_sql_example("SELECT RS_Example()".to_string()) + .build() +} + +#[derive(Debug)] +struct RsExample {} + +impl SedonaScalarKernel for RsExample { + fn return_type(&self, args: &[SedonaType]) -> Result<Option<SedonaType>> { + let matcher = ArgMatcher::new(vec![], SedonaType::Raster); + + matcher.match_args(args) + } + + fn invoke_batch( + &self, + arg_types: &[SedonaType], + args: &[ColumnarValue], + ) -> Result<ColumnarValue> { + let executor = RasterExecutor::new(arg_types, args); + let mut builder = RasterBuilder::new(1); + + let raster_metadata = RasterMetadata { + width: 64, + height: 32, + upperleft_x: 43.08, + upperleft_y: 79.07, + scale_x: 2.0, + scale_y: 2.0, + skew_x: 1.0, + skew_y: 1.0, + }; + let crs = lnglat().unwrap().to_json(); + builder.start_raster(&raster_metadata, Some(&crs))?; + let nodata_value = 127u8; + for band_id in 1..=3 { + builder.start_band(BandMetadata { + datatype: BandDataType::UInt8, + nodata_value: Some(vec![nodata_value]), + storage_type: StorageType::InDb, + outdb_url: None, + outdb_band_id: None, + })?; + + let mut band_data = + vec![band_id as u8; (raster_metadata.width * raster_metadata.height) as usize]; + band_data[0] = nodata_value; // set the top corner to nodata + + builder.band_data_writer().append_value(&band_data); + builder.finish_band()?; + } + builder.finish_raster()?; + + executor.finish(Arc::new(builder.finish()?)) + } +} + +#[cfg(test)] +mod tests { + use super::*; + use datafusion_common::ScalarValue; + use datafusion_expr::ScalarUDF; + use sedona_raster::array::RasterStructArray; + use sedona_raster::traits::RasterRef; + use sedona_schema::datatypes::RASTER; + + #[test] + fn udf_size() { + let udf: ScalarUDF = rs_example_udf().into(); + assert_eq!(udf.name(), "rs_example"); + assert!(udf.documentation().is_some()); + } + + #[test] + fn udf_invoke() { + let kernel = RsExample {}; + let args = []; + let arg_types = vec![RASTER]; Review Comment: The arg_types should be an empty vector since RS_Example takes no arguments. This mismatch between the actual arguments (empty args array on line 130) and arg_types causes incorrect type checking. ```suggestion let arg_types = vec![]; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
