paleolimbot opened a new issue, #313:
URL: https://github.com/apache/sedona-db/issues/313

   From https://github.com/apache/sedona-db/pull/312
   
   > perhaps we have too many of the rust level benchmarks and should remove 
some, or change the process of running them
   
   Currently we have a lot of Rust level benchmarks that are traditional 
Criterion benchmarks.
   
   
https://github.com/apache/sedona-db/blob/e8f4c5e338c61a52dd2994c11943f3f0b546536d/rust/sedona-functions/benches/native-functions.rs#L21-L28
   
   These are useful when comparing between kernel implementations of the same 
function; however, we have a lot of them and we don't actually run them except 
to make sure they run once with tiny data or on specific PRs that update a 
kernel implementation. I think we may be able to reduce this to a single 
"benchmark" per function-providing crate that enabled the function name and the 
`ArrayArray(Point, LineString(10))` to be parsed at runtime somehow (e.g., 
`cargo bench -p sedona-geos -- st_make_valid "LineString(10)"`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to