paleolimbot opened a new issue, #370:
URL: https://github.com/apache/sedona-db/issues/370

   In https://github.com/apache/sedona-db/pull/360 we added a basic but awkward 
means by which to "sort by geometry". There are some improvements we need to 
make once we have some experience with it:
   
   > Maybe it's just me, but this feels a little awkward. I would definitely 
expect the default ordering of sd_order to have meaning. 
https://github.com/apache/sedona-db/pull/360#discussion_r2566209846
   
   This is a great point...we can improve this situation by (1) erroring (i.e., 
refuse to sort if we're not sure it will be meaningful) and (2) removing the 
need for s2geography for computing the ordering (it's in most of our builds but 
not R yet). For most input/current released builds, the ordering will be 
meaningful.
   
   > Why do we call it SD_Order? If this is a UDF, why not ST?
   > Can we add docs together with the PR if possible?
   
   A missing piece from the initial PR to the final interface here is the 
logical optimizer rule that transforms `ORDER BY geometry` to `ORDER BY 
sd_order(geometry)`. We have `sd_format()` as well and will likely add 
`sd_cast()` soon as they are called in a similar (internal) way.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to