paleolimbot commented on code in PR #360: URL: https://github.com/apache/sedona-db/pull/360#discussion_r2566322044
########## rust/sedona-functions/src/sd_order.rs: ########## @@ -0,0 +1,118 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use datafusion_common::Result; +use datafusion_expr::{ + scalar_doc_sections::DOC_SECTION_OTHER, ColumnarValue, Documentation, Volatility, +}; +use sedona_expr::scalar_udf::{SedonaScalarKernel, SedonaScalarUDF}; +use sedona_schema::datatypes::SedonaType; +use std::{fmt::Debug, sync::Arc}; + +/// SD_Order() scalar UDF implementation +/// +/// This function is invoked to obtain a proxy array whose order may be used +/// to sort based on the value. The default implementation returns the value +/// and a utility is provided to order geometry and/or geographies based on +/// the first coordinate. More sophisticated sorting (e.g., XZ2) may be added +/// in the future. +pub fn sd_order_udf() -> SedonaScalarUDF { Review Comment: That's a great point...I added https://github.com/apache/sedona-db/issues/370 for some improvements. For the most part the ordering that will happen in our release builds for most input will be meaningful (exceptions: `None` crs, missing s2geography, missing proj config). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
