paleolimbot commented on code in PR #381:
URL: https://github.com/apache/sedona-db/pull/381#discussion_r2572075946
##########
rust/sedona-functions/benches/native-functions.rs:
##########
@@ -82,6 +82,21 @@ fn criterion_benchmark(c: &mut Criterion) {
benchmark::scalar(c, &f, "native", "st_hasm", Point);
benchmark::scalar(c, &f, "native", "st_hasm", LineString(10));
+ benchmark::scalar(
+ c,
+ &f,
+ "native",
+ "st_interiorringn",
+ BenchmarkArgs::ArrayArray(Polygon(10), Int64(1, 10)),
+ );
Review Comment:
We'd need a new `BenchmarkArgSpec` (maybe `PolygonWithHole`) here:
https://github.com/apache/sedona-db/blob/16d232be0f28441b85801936b270fa43f7edceb4/rust/sedona-testing/src/benchmark_util.rs#L275-L276
...and it would need to be added to `build_geometry()`:
https://github.com/apache/sedona-db/blob/16d232be0f28441b85801936b270fa43f7edceb4/rust/sedona-testing/src/benchmark_util.rs#L421-L429
(the polygon hole rate is something you can specify to the random
partitioned data builder)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
