petern48 commented on PR #386: URL: https://github.com/apache/sedona-db/pull/386#issuecomment-3591890245
Last thing, two things. The first is good practice for all repos. The second is specific to this SedonaDB repo. - Could you mention the [issue](https://github.com/apache/sedona-db/issues/224) that this is a part of inside the PR description? - We don't want to say "closes" since the issue isn't done, but I like to do something like `"part of <issue link>"` - It's important to mention it, so that GitHub creates a link in that issue to this PR (e.g. shown below). When others view that issue, they can see that you have already started on implementing this function. When you don't do this, it increases the odds of someone trying to implement it too, since they might not see that you opened a PR for it already. - Could you also update the PR title to follow this convention we've been following for this repo: - `feat(c/sedona-geos): Implement ST_NumPoints` - "feat" is short for for feature. "c/sedona-geos" is the directory the change is in. It doesn't matter if you say "Add" or "Implement" Also, for the future, try to do both of these when you first open the PR, especially the first one, to avoid chances of duplicate PRs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
