petern48 commented on code in PR #325:
URL: https://github.com/apache/sedona-db/pull/325#discussion_r2596550801
##########
rust/sedona-functions/src/st_analyze_agg.rs:
##########
@@ -41,40 +41,40 @@ use wkb::reader::Wkb;
use crate::executor::WkbExecutor;
-/// ST_Analyze_Aggr() aggregate UDF implementation
+/// ST_Analyze_Agg() aggregate UDF implementation
///
/// This function computes comprehensive statistics for a collection of
geometries.
/// It returns a struct containing various metrics such as count, min/max
coordinates,
/// mean size, and geometry type counts.
-pub fn st_analyze_aggr_udf() -> SedonaAggregateUDF {
+pub fn st_analyze_agg_udf() -> SedonaAggregateUDF {
SedonaAggregateUDF::new(
- "st_analyze_aggr",
- vec![Arc::new(STAnalyzeAggr {})],
+ "st_analyze_agg",
+ vec![Arc::new(STAnalyzeAgg {})],
Volatility::Immutable,
- Some(st_analyze_aggr_doc()),
+ Some(st_analyze_agg_doc()),
)
Review Comment:
dang, i'm only just catching this right after the release... shouldn't we
have maintained the old `_Aggr` suffix for backwards compatibility? Datafusion
makes adding aliases easy for us. Would it still be worth re-introducing the
old suffix for the following release, or nah?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
