paleolimbot commented on code in PR #310: URL: https://github.com/apache/sedona-db/pull/310#discussion_r2599916006
########## c/sedona-libgpuspatial/libgpuspatial/include/gpuspatial/relate/im.cuh: ########## @@ -0,0 +1,59 @@ +/* + * PG-Strom Extension for GPU Acceleration on PostgreSQL Database + * + * Copyright (c) 2012-2024, KaiGai Kohei <[email protected]> + * Copyright (c) 2017-2024, HeteroDB,Inc <[email protected]> + * + * Permission to use, copy, modify, and distribute this software and its + * documentation for any purpose, without fee, and without a written agreement + * is hereby granted, provided that the above copyright notice and this + * paragraph and the following two paragraphs appear in all copies. + * + * IN NO EVENT SHALL HETERODB,INC BE LIABLE TO ANY PARTY FOR DIRECT, INDIRECT, + * SPECIAL, INCIDENTAL, OR CONSEQUENTIAL DAMAGES, INCLUDING LOST PROFITS, + * ARISING OUT OF THE USE OF THIS SOFTWARE AND ITS DOCUMENTATION, + * EVEN IF HETERODB,INC HAS BEEN ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + * + * HETERODB,INC SPECIFICALLY DISCLAIMS ANY WARRANTIES, INCLUDING, BUT NOT LIMITED TO, + * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE. + * THE SOFTWARE PROVIDED HEREUNDER IS ON AN "AS IS" BASIS, AND HETERODB,INC HAS + * NO OBLIGATIONS TO PROVIDE MAINTENANCE, SUPPORT, UPDATES, ENHANCEMENTS, OR MODIFICATIONS. + */ + +#pragma once +// octal numbers, +/** Intersection Matrix (IM) defined by octal numbers + * Dimension Octal Binary Meaning + * F 0 0 Empty set (no intersection) + * 0D 1 001 Point-dimensional intersection + * 1D 3 011 Line-dimensional intersection + * 2D 7 111 Area-dimensional intersection + */ +#define IM__INTER_INTER_0D 0000000001U Review Comment: I see this is included in im.cuh ########## c/sedona-libgpuspatial/libgpuspatial/test/geoarrow_geos/geoarrow_geos.c: ########## @@ -0,0 +1,1101 @@ + +#include <errno.h> Review Comment: You've copied enough of it here that it needs to be acknowledged in LICENSE. I filed https://github.com/geoarrow/geoarrow-c-geos/issues/6 so that hopefully we can avoid a vendor in the future. ########## c/sedona-libgpuspatial/libgpuspatial/NOTICE: ########## Review Comment: That was copied over from apache/sedona and doesn't apply here...if we get complaints that the LICENSES file is unweildy or inappropriately formatted we can update its structure. Some Apache projects use licenses/, some use NOTICE.txt, or some inline everything into LICENSE. The important part is that vendored dependencies are acknowledged somewhere. This file is also missing geoarrow-c-geos. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
