pwrliang commented on code in PR #465:
URL: https://github.com/apache/sedona-db/pull/465#discussion_r2633594132
##########
c/sedona-libgpuspatial/CMakeLists.txt:
##########
Review Comment:
This file is not used and can be removed
##########
c/sedona-libgpuspatial/build.rs:
##########
@@ -157,6 +158,7 @@ fn main() {
println!("cargo:rustc-link-lib=static=gpuspatial");
println!("cargo:rustc-link-lib=static=rmm");
println!("cargo:rustc-link-lib=static=rapids_logger");
+ println!("cargo:rustc-link-lib=static=spdlog");
Review Comment:
Should we remove this ".define("CMAKE_BUILD_TYPE", "Release")"
and let Cargo to determine the compiling mode?
Under Debug mode, the product of spdlog is named "spdlogd" while in the
release mode, it is "spdlog" The following code can automatically determine
linking to which target according to the building model
```rust
let profile_mode = if cfg!(debug_assertions) {
"debug"
} else {
"release"
};
// Use the 'd' suffix for the debug build of spdlog (libspdlogd.a)
let spdlog_lib_name = if profile_mode == "debug" {
"spdlogd"
} else {
"spdlog"
};
println!(
"cargo:warning=Linking spdlog in {} mode: lib{}.a",
profile_mode, spdlog_lib_name
);
println!("cargo:rustc-link-lib=static={}", spdlog_lib_name);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
