petern48 commented on code in PR #476:
URL: https://github.com/apache/sedona-db/pull/476#discussion_r2656970471


##########
python/sedonadb/tests/functions/test_functions.py:
##########
@@ -874,17 +827,70 @@ def test_st_convexhull(eng, geom, expected):
             "GEOMETRYCOLLECTION (POLYGON ((0 0, 1 0, 1 1, 0 1, 0 0)), POLYGON 
((1 0, 2 0, 2 1, 1 1, 1 0)))",
             "POLYGON ((0 0, 0 1, 1 1, 2 1, 2 0, 1 0, 0 0))",
         ),
+        # Z and M support
+        ("POINT Z (0 0 0)", "POINT Z(0 0 0)"),
+        ("POINT M (1 2 3)", "POINT M(1 2 3)"),
+        ("POINT ZM (1 2 3 4)", "POINT ZM(1 2 3 4)"),
+        ("LINESTRING Z (0 0 0, 1 1 1)", "LINESTRING Z(0 0 0,1 1 1)"),

Review Comment:
   I mainly added these Z/M tests for st_unaryunion as a more convenient way to 
test `geos_to_wkb.rs`. I need to add rust tests. We can keep them or delete 
them, but Z/M support is new here since `.to_wkb()` apparently doesn't support 
them.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to