Copilot commented on code in PR #492:
URL: https://github.com/apache/sedona-db/pull/492#discussion_r2666882088
##########
rust/sedona-functions/src/st_asbinary.rs:
##########
@@ -100,7 +103,15 @@ mod tests {
}
#[rstest]
- fn udf_geometry_input(#[values(WKB_GEOMETRY, WKB_GEOGRAPHY)] sedona_type:
SedonaType) {
+ fn udf_geometry_input(
+ #[values(
+ WKB_GEOMETRY,
+ WKB_GEOGRAPHY,
+ WKB_GEOMETRY_ITEM_CRS.clone(),
+ WKB_GEOMETRY_ITEM_CRS.clone(),
Review Comment:
Duplicate test value detected. Line 111 repeats
`WKB_GEOMETRY_ITEM_CRS.clone()` which was already specified on line 110. The
second instance should likely be `WKB_GEOGRAPHY_ITEM_CRS.clone()` to test
geography item CRS types.
```suggestion
WKB_GEOGRAPHY_ITEM_CRS.clone(),
```
##########
rust/sedona-functions/src/st_geometrytype.rs:
##########
@@ -134,7 +139,10 @@ mod tests {
}
#[rstest]
- fn udf(#[values(WKB_GEOMETRY, WKB_VIEW_GEOMETRY)] sedona_type: SedonaType)
{
+ fn udf(
+ #[values(WKB_GEOMETRY, WKB_VIEW_GEOMETRY, WKB_GEOGRAPHY,
WKB_GEOGRAPHY, WKB_GEOMETRY_ITEM_CRS.clone(), WKB_GEOMETRY_ITEM_CRS.clone())]
+ sedona_type: SedonaType,
+ ) {
Review Comment:
Duplicate test values detected. `WKB_GEOGRAPHY` appears twice (line 143) and
`WKB_GEOMETRY_ITEM_CRS.clone()` appears twice (line 143). The second
`WKB_GEOGRAPHY` should likely be `WKB_VIEW_GEOGRAPHY`, and the second
`WKB_GEOMETRY_ITEM_CRS.clone()` should likely be
`WKB_GEOGRAPHY_ITEM_CRS.clone()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
