Copilot commented on code in PR #497:
URL: https://github.com/apache/sedona-db/pull/497#discussion_r2670833292
##########
ci/scripts/wheels-build-macos.sh:
##########
@@ -31,8 +31,12 @@ fi
SOURCE_DIR="$(cd "$(dirname "${BASH_SOURCE[0]:-$0}")" && pwd)"
SEDONADB_DIR="$(cd "${SOURCE_DIR}/../.." && pwd)"
+# Default to arm64 but allow override to x86_64
+SEDONADB_MACOS_ARCH=${SEDONADB_MACOS_ARCH:-arm64}
+
# Ensure we have our VCPKG_ROOT set and bootstrapped
-export VCPKG_DEFAULT_TRIPLET=arm64-osx-dynamic-release
+SEDONADB_MACOS_ARCH_TRIPLET="${SEDONADB_MACOS_ARCH//_/-}"
+export
VCPKG_DEFAULT_TRIPLET="${SEDONADB_MACOS_ARCH_TRIPLET}-osx-dynamic-release"
Review Comment:
The variable name SEDONADB_MACOS_ARCH_TRIPLET is misleading. This variable
performs string substitution (replacing underscore with hyphen) on the
architecture name, but 'triplet' suggests it's the full triplet name. Consider
renaming to SEDONADB_MACOS_ARCH_NORMALIZED or SEDONADB_MACOS_ARCH_HYPHENATED to
better reflect that it's just the normalized architecture component.
```suggestion
SEDONADB_MACOS_ARCH_HYPHENATED="${SEDONADB_MACOS_ARCH//_/-}"
export
VCPKG_DEFAULT_TRIPLET="${SEDONADB_MACOS_ARCH_HYPHENATED}-osx-dynamic-release"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
