Kontinuation commented on code in PR #521: URL: https://github.com/apache/sedona-db/pull/521#discussion_r2696664322
########## rust/sedona-spatial-join/src/evaluated_batch/evaluated_batch_stream/evaluate.rs: ########## @@ -0,0 +1,162 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use std::pin::Pin; +use std::sync::Arc; +use std::task::{Context, Poll}; + +use arrow_array::RecordBatch; +use arrow_schema::{DataType, SchemaRef}; +use datafusion_common::Result; +use datafusion_physical_plan::{metrics, SendableRecordBatchStream}; +use futures::{Stream, StreamExt}; + +use crate::evaluated_batch::{ + evaluated_batch_stream::{EvaluatedBatchStream, SendableEvaluatedBatchStream}, + EvaluatedBatch, +}; +use crate::operand_evaluator::{EvaluatedGeometryArray, OperandEvaluator}; +use crate::utils::arrow_utils::compact_batch; + +/// An evaluator that can evaluate geometry expressions on record batches +/// and produces evaluated geometry arrays. +trait Evaluator: Unpin { + fn evaluate(&self, batch: &RecordBatch) -> Result<EvaluatedGeometryArray>; +} + +/// An evaluator for build-side geometry expressions. +struct BuildSideEvaluator { + evaluator: Arc<dyn OperandEvaluator>, +} + +impl Evaluator for BuildSideEvaluator { + fn evaluate(&self, batch: &RecordBatch) -> Result<EvaluatedGeometryArray> { + self.evaluator.evaluate_build(batch) + } +} + +/// An evaluator for probe-side geometry expressions. +struct ProbeSideEvaluator { + evaluator: Arc<dyn OperandEvaluator>, +} + +impl Evaluator for ProbeSideEvaluator { + fn evaluate(&self, batch: &RecordBatch) -> Result<EvaluatedGeometryArray> { + self.evaluator.evaluate_probe(batch) + } +} + +/// Wraps a `SendableRecordBatchStream` and evaluates the probe-side geometry +/// expression eagerly so downstream consumers can operate on `EvaluatedBatch`s. +struct EvaluateOperandBatchStream<E: Evaluator> { + inner: SendableRecordBatchStream, + evaluator: E, + evaluation_time: metrics::Time, + gc_view_arrays: bool, +} + +impl<E: Evaluator> EvaluateOperandBatchStream<E> { + fn new( + inner: SendableRecordBatchStream, + evaluator: E, + evaluation_time: metrics::Time, + gc_view_arrays: bool, + ) -> Self { + let gc_view_arrays = gc_view_arrays && schema_contains_view_types(&inner.schema()); + Self { + inner, + evaluator, + evaluation_time, + gc_view_arrays, + } + } +} + +/// Checks if the schema contains any view types (Utf8View or BinaryView). +fn schema_contains_view_types(schema: &SchemaRef) -> bool { + schema + .flattened_fields() + .iter() + .any(|field| matches!(field.data_type(), DataType::Utf8View | DataType::BinaryView)) +} Review Comment: Added test coverage for `schema_contains_view_types` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
