Kontinuation commented on code in PR #523:
URL: https://github.com/apache/sedona-db/pull/523#discussion_r2698992011
##########
rust/sedona-spatial-join/src/stream.rs:
##########
@@ -242,54 +250,51 @@ impl SpatialJoinStream {
}
}
- fn process_probe_batch(&mut self) ->
Poll<Result<StatefulStreamResult<Option<RecordBatch>>>> {
- let timer = self.join_metrics.join_time.timer();
+ fn process_probe_batch(
+ &mut self,
+ cx: &mut std::task::Context<'_>,
+ ) -> Poll<Result<StatefulStreamResult<Option<RecordBatch>>>> {
+ let _timer = self.join_metrics.join_time.timer();
Review Comment:
It is a commonly used idiom in DataFusion code. Removing the underscore
prefix will introduce a compiler warning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
