Copilot commented on code in PR #76:
URL:
https://github.com/apache/sedona-spatialbench/pull/76#discussion_r2706665293
##########
.github/workflows/benchmark.yml:
##########
@@ -84,6 +94,9 @@ env:
DUCKDB_VERSION: ${{ github.event.inputs.duckdb_version }}
GEOPANDAS_VERSION: ${{ github.event.inputs.geopandas_version }}
SPATIAL_POLARS_VERSION: ${{ github.event.inputs.spatial_polars_version }}
+ # Nightly build options (default: true)
+ SEDONADB_NIGHTLY: ${{ github.event.inputs.sedonadb_nightly || 'true' }}
+ DUCKDB_NIGHTLY: ${{ github.event.inputs.duckdb_nightly || 'true' }}
Review Comment:
The default value 'true' is a string rather than a boolean, which requires
string comparison later (e.g., '= \"true\"'). This is inconsistent with the
boolean type definition in the workflow inputs. While functional, consider
using GitHub Actions' native boolean handling or documenting why string
comparison is necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
