pwrliang commented on code in PR #465:
URL: https://github.com/apache/sedona-db/pull/465#discussion_r2710639058
##########
rust/sedona-spatial-join/src/exec.rs:
##########
@@ -1338,13 +1408,16 @@ mod tests {
let spatial_join_execs = collect_spatial_join_exec(&plan)?;
assert_eq!(spatial_join_execs.len(), 1);
let original_exec = spatial_join_execs[0];
+ let use_gpu = cfg!(feature = "gpu");
+
let mark_exec = SpatialJoinExec::try_new(
original_exec.left.clone(),
original_exec.right.clone(),
original_exec.on.clone(),
original_exec.filter.clone(),
&join_type,
None,
+ use_gpu,
Review Comment:
I initially thought we would run tests twice with and without `--features
gpu`. This can eliminate duplicated code. However, I think it is more natural
to run both CPU and GPU tests when using `--features gpu`. I have updated the
tests accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
