Copilot commented on code in PR #499:
URL: https://github.com/apache/sedona-db/pull/499#discussion_r2722197295
##########
r/sedonadb/src/rust/src/expression.rs:
##########
@@ -17,7 +17,7 @@
use std::sync::Arc;
-use datafusion_common::{Column, ScalarValue};
+use datafusion_common::{Column, Result, ScalarValue};
Review Comment:
The import of 'Result' from datafusion_common appears unused in this file.
The only Result type used is from savvy::Result.
```suggestion
use datafusion_common::{Column, ScalarValue};
```
##########
r/sedonadb/src/rust/src/dataframe.rs:
##########
@@ -311,4 +313,21 @@ impl InternalDataFrame {
let inner = self.inner.clone().select(exprs)?;
Ok(new_data_frame(inner, self.runtime.clone()))
}
+
+ fn select(&self, exprs_sexp: savvy::Sexp) ->
savvy::Result<InternalDataFrame> {
Review Comment:
The method name 'select' conflicts with the existing public method
'select_indices' at line 313. Consider renaming this method to 'select_exprs'
to clearly distinguish it from the index-based selection method.
```suggestion
fn select_exprs(&self, exprs_sexp: savvy::Sexp) ->
savvy::Result<InternalDataFrame> {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
