jiayuasu opened a new pull request, #2613: URL: https://github.com/apache/sedona/pull/2613
## Did you read the Contributor Guide? - Yes, I have read the [Contributor Rules](https://sedona.apache.org/latest/community/rule/) and [Contributor Development Guide](https://sedona.apache.org/latest/community/develop/) ## Is this PR related to a ticket? - Yes, and the PR name follows the format `[GH-XXX] my subject`. Closes #2148 ## What changes were proposed in this PR? This pull request enhances the `ST_MakePolygon` function to better align its behavior and documentation with PostGIS, particularly regarding the handling of holes that are not fully contained within the shell. It introduces warnings when holes are outside the shell, updates documentation and examples to clarify this behavior, and adds comprehensive tests to verify the function's correctness in these scenarios. ## How was this patch tested? * Added new tests in `FunctionsTest.java` to cover polygons with valid holes, holes outside the shell, and holes partially outside the shell, ensuring correct behavior and validity checks. * Updated a test description in `StMakePolygonSpec.scala` to clarify that polygons with holes are created even if holes are outside the shell, matching PostGIS. ## Did this PR include necessary documentation updates? - Yes, I have updated the documentation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
