2010YOUY01 commented on PR #580: URL: https://github.com/apache/sedona-db/pull/580#issuecomment-3875398385
> Thank you for opening! > > This has been proposed before, although this is tricky for me personally because when I work on the R or Python bindings I often don't want to run a command that builds the entire project (i.e., I've always preferred a pre-commit that can run in a trivial amount of time since I run it frequently). I use an IDE configuration to run clippy and I think it can be installed as a git pre-commit hook independently if somebody prefers? > > Happy to hear dissenting opinions! Thank you for the review! I agree it would be better to separate fast and slow checks. WDYT making clippy a pre-push hook: it only triggers on `git push`. I made the change in [301e4a5](https://github.com/apache/sedona-db/pull/580/commits/301e4a54ae124dcc10ea5c70ca5f128c9b651836), and have it tested locally: ```sh # setup pre-commit install --hook-type pre-push (.venv) yongting@Yongtings-MacBook-Pro-2 ~/C/sedona-db (pre-commit-clippy +)> git commit --amend -m "Review: make clippy pre-push hook instead" ... clang-format.........................................(no files to check)Skipped [pre-commit-clippy 301e4a5] Review: make clippy pre-push hook instead Date: Tue Feb 10 13:04:33 2026 +0800 1 file changed, 3 insertions(+), 1 deletion(-) (.venv) yongting@Yongtings-MacBook-Pro-2 ~/C/sedona-db (pre-commit-clippy)> git push -f origin pre-commit-clippy ... clang-format.........................................(no files to check)Skipped cargo clippy fix workspace (best effort).............(no files to check)Skipped <--- Only runs on `git push` ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
