paleolimbot commented on PR #71: URL: https://github.com/apache/sedona-spatialbench/pull/71#issuecomment-3893511163
> Testing against an actual S3 endpoint would mostly be validating not our code There's nothing in this PR to indicate that `spatialbench-cli -s 1 --format=parquet --output-dir s3://my-bucket/sf1-parquet` actually runs (and nothing to ensure that future LLMs or contributors won't break it). I call this an "is it plugged in check" and I while I think future you will be glad you added it now, the consequences of this not working are very low (and not my problem 🙂 ) so feel free to punt! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
