Kontinuation commented on code in PR #641:
URL: https://github.com/apache/sedona-db/pull/641#discussion_r2834209843
##########
rust/sedona-spatial-join/src/planner/spatial_expr_utils.rs:
##########
@@ -2309,4 +2365,196 @@ mod tests {
let names = collect_spatial_predicate_names(&non_spatial_and);
assert!(names.is_empty());
}
+
+ #[test]
+ fn test_find_st_knn_call_simple() {
+ let st_knn_udf = create_dummy_st_knn_udf();
+ let expr = Expr::ScalarFunction(ScalarFunction {
+ func: st_knn_udf,
+ args: vec![col("l.geom"), col("r.geom"), lit(5i32), lit(false)],
+ });
Review Comment:
It would require registering UDFs with a SessionContext, which adds
complexity for what are currently straightforward unit tests. I have replaced
these using `st_knn_udf.call`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
