jiayuasu opened a new pull request, #2701:
URL: https://github.com/apache/sedona/pull/2701

   ## Did you read the Contributor Guide?
   
   - Yes, I have read the [Contributor 
Rules](https://sedona.apache.org/latest/community/rule/) and [Contributor 
Development Guide](https://sedona.apache.org/latest/community/develop/)
   
   ## Is this PR related to a ticket?
   
   - Yes, and the PR name follows the format `[GH-XXX] my subject`. Closes #2230
   
   ## What changes were proposed in this PR?
   
   Implement four GeoSeries methods by delegating to Sedona ST functions:
   
   - `reverse()` → `ST_Reverse`
   - `normalize()` → `ST_Normalize`
   - `representative_point()` → `ST_PointOnSurface`
   - `line_merge()` → `ST_LineMerge`
   
   Each function follows the established pattern from #2232:
   - **base.py**: Docstring with examples + `_delegate_to_geometry_column` call
   - **geoseries.py**: ST function call via `_query_geometry_column`
   - **test_geoseries.py**: Unit test with expected values + GeoDataFrame 
delegation test
   - **test_match_geopandas_series.py**: Comparison test against real geopandas 
output
   
   Note: `line_merge` tests are scoped to `MultiLineString` inputs only, since 
Sedona's `ST_LineMerge` returns `GEOMETRYCOLLECTION EMPTY` for 
non-MultiLineString geometries (e.g., bare `LineString`), while geopandas 
passes them through unchanged.
   
   ## How was this patch tested?
   
   Added tests in:
   - `test_geoseries.py`: 4 new tests (`test_reverse`, `test_normalize`, 
`test_representative_point`, `test_line_merge`)
   - `test_match_geopandas_series.py`: 4 new tests comparing Sedona GeoSeries 
output against geopandas
   
   All 8 tests pass locally. No regressions in existing tests.
   
   ## Did this PR include necessary documentation updates?
   
   - No, this PR does not affect any public API so no need to change the 
documentation.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to