Copilot commented on code in PR #2710:
URL: https://github.com/apache/sedona/pull/2710#discussion_r2916493836
##########
python/sedona/spark/geopandas/base.py:
##########
@@ -1093,8 +1303,38 @@ def force_3d(self, z=0.0):
"""
return _delegate_to_geometry_column("force_3d", self, z)
- # def line_merge(self, directed=False):
- # raise NotImplementedError("This method is not implemented yet.")
+ def line_merge(self, directed=False):
+ """Return merged LineStrings.
+
+ Returns a ``GeoSeries`` of (Multi)LineStrings, where connected
+ LineStrings are merged together into single LineStrings.
+
+ Parameters
+ ----------
+ directed : bool, default False
+ Currently not supported by Sedona.
Review Comment:
The docstring for `line_merge` says `directed` is “not supported”, but the
GeoSeries implementation raises `NotImplementedError` when `directed=True`.
Please document this explicitly (e.g., that `directed=True` will raise) to
avoid implying the argument is silently ignored.
```suggestion
Only ``directed=False`` is supported. Passing ``directed=True``
will raise ``NotImplementedError``.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
