jbampton opened a new pull request, #2752:
URL: https://github.com/apache/sedona/pull/2752

   Apache Airflow uses this same "insert-license" hook for RST files
   
   
https://github.com/apache/airflow/blob/d1455c892fedf1256ed88e389bd0ededad8ad4a4/.pre-commit-config.yaml#L73
   
   
https://github.com/apache/airflow/blob/main/scripts/ci/license-templates/LICENSE.rst
   
   We already use pre-commit to insert licenses for other files
   
   ## Did you read the Contributor Guide?
   
   - Yes, I have read the [Contributor 
Rules](https://sedona.apache.org/latest/community/rule/) and [Contributor 
Development Guide](https://sedona.apache.org/latest/community/develop/)
   
   ## Is this PR related to a ticket?
   
   - No:
     - this is a CI update. The PR name follows the format `[CI] my subject`
   
   ## What changes were proposed in this PR?
   
   Added another check / test to our pre-commit framework
   
   ## How was this patch tested?
   
   - Ran: `sedona$ pre-commit run --all-files` to test the insert license hook 
both before and after the license headers were auto inserted
   - opened and viewed some of the RST files in my IDE PyCharm in both editor 
and preview mode after the license headers were inserted
   - Ran: `sedona$ cd python/sedona/doc; make html` and viewed the generated 
HTML files in `_build` folder in my IDE and no license headers were present.  
Also opened some of these HTML files in Firefox and they display correctly
   
   ## Did this PR include necessary documentation updates?
   
   - No, this PR does not affect any public API so no need to change the 
documentation.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to