Mehak3010 commented on code in PR #691:
URL: https://github.com/apache/sedona-db/pull/691#discussion_r2940446907
##########
python/sedonadb/tests/functions/test_predicates.py:
##########
@@ -442,3 +438,34 @@ def test_st_overlaps(eng, geom1, geom2, expected):
f"SELECT ST_Overlaps({geom_or_null(geom1)}, {geom_or_null(geom2)})",
expected,
)
+
+
[email protected]("eng", [SedonaDB, PostGIS])
[email protected](
+ ("geom1", "geom2", "expected"),
+ [
+ (None, None, None),
+ ("POINT (0 0)", None, None),
+ (None, "POINT (0 0)", None),
+ ("POINT (0 0)", "POINT (1 1)", "FF0FFF0F2"),
+ ("POINT (0 0)", "POINT (0 0)", "0FFFFFFF2"),
+ ("POINT (0 0)", "POLYGON ((0 0, 1 0, 1 1, 0 1, 0 0))", "F0FFFF212"),
+ ("POINT (0.5 0.5)", "POLYGON ((0 0, 1 0, 1 1, 0 1, 0 0))",
"0FFFFF212"),
+ (
+ "POLYGON ((0 0, 1 0, 1 1, 0 1, 0 0))",
+ "POLYGON ((5 5, 6 5, 6 6, 5 6, 5 5))",
+ "FF2FF1212",
+ ),
+ (
+ "POLYGON ((0 0, 2 0, 2 2, 0 2, 0 0))",
+ "POLYGON ((1 1, 3 1, 3 3, 1 3, 1 1))",
+ "212101212",
+ ),
Review Comment:
Thanks for the suggestion! I’ll add these edge cases to the Python tests and
determine the expected outputs by comparing SedonaDB and PostGIS results.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
