paleolimbot opened a new issue, #817:
URL: https://github.com/apache/sedona-db/issues/817

   I removed a few test cases when importing test cases from s2geography into 
our Python integration tests in https://github.com/apache/sedona-db/pull/816 .
   
   ```python
           # Polygon contains interior sub-polygon with shared boundary
           pytest.param(
               "POLYGON ((0 0, 2 0, 0 2, 0 0))",
               "POLYGON ((0 0, 0.5 0, 0 0.5, 0 0))",
               True,
               id="polygon_contains_interior_polygon",
           ),
           # Linestring contains an interior point
           pytest.param(
               "LINESTRING (0 0, 1 0)",
               "POINT (0.5 0)",
               True,
               id="linestring_contains_interior_point",
           ),
           # Linestring contains an interior linestring
           pytest.param(
               "LINESTRING (0 0, 2 0)",
               "LINESTRING (0 0, 1 0)",
               True,
               id="linestring_contains_interior_linestring",
           ),
   ```
   
   The expected values above are BigQuery's result (and I believe the result 
that would be expected for the geometry case). PostGIS doesn't implement 
Contains for geography so we can't compare that (but it does implement covers).
   
   One of the tricky things about non-vertex boundaries in Geography is that it 
is exceedingly rare for a point to be exactly on a great circle between two 
vertices...these test cases are contrived but do expose a hole in the 
s2geography testing (I am not sure there's a good test case for the difference 
between contains and covers where the vertices are exactly the same).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to