jiayuasu commented on PR #2905:
URL: https://github.com/apache/sedona/pull/2905#issuecomment-4385587110
Pushed `ae359a7640`.
| Review point | Action |
|---|---|
| Section 4 markdown documents the struct as `{geom, val, x, y}` and filters
on `val = 1`, but the code uses `pixel.value` and `where("value = 1")` |
Updated the markdown to `{geom, value, x, y}` and `value = 1` so the prose
matches what readers see in the SQL. |
| Pipeline-overview step 6 says critical = `type != 'residential'`, but the
actual query uses an explicit IN list | Changed the overview to `type IN
('hospital', 'school', 'fire_station')` to match the implemented condition.
Stays correct if more non-residential, non-critical types are added later. |
Markdown-only. Executable cells were already correct (the second-run PASS on
commit `2ea528d7b2` exercised them); no re-run needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
