jiayuasu commented on PR #937: URL: https://github.com/apache/sedona-db/pull/937#issuecomment-4674110963
Thanks for the review! Addressed in 7f6efc1: - **CamelCase → snake_case** name derivation (`MyMean` → `my_mean`). - **Shapely-based geo aggregate test** — `test_aggregate_udf_shapely_geometry` unions input points and returns a geometry through `ga.wkb()`, exercising GEOMETRY in + geo out. - **Exception-in-each-method test** — `test_aggregate_udf_exception_in_method_propagates` is parametrized over `update`/`state`/`merge`/`evaluate` (grouped multi-batch input so state/merge actually run); each surfaces as an error rather than crashing. - **More error pathways** — re-added `test_aggregate_udf_state_arity_mismatch_raises` (state() returning the wrong number of elements) alongside the existing wrong-return-type case. Aggregate test count is now 13. The `lit()` suggestion and the GroupsAccumulator/GIL optimization I'd like to take as focused follow-ups (replied inline with the reasoning) — geometry returns already work via WKB today. CI is green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
