Copilot commented on code in PR #935:
URL: https://github.com/apache/sedona-db/pull/935#discussion_r3392852171
##########
python/sedonadb/python/sedonadb/dataframe.py:
##########
@@ -1455,7 +1477,7 @@ def _create_data_frame(ctx, obj, schema) -> DataFrame:
# __datafusion_table_provider__ or __arrow_c_stream__. For objects
implementing
# __arrow_c_stream__, this currently will only work for a single scan
(i.e.,
# the returned data frame can't be previewed before the query is computed).
- return _scan_default(ctx, obj, schema)
+ return _scan_default(ctx, obj, schema)._ensure_aliased(obj)
Review Comment:
_create_data_frame() only applies the new default aliasing to the generic
scan path; objects handled via SPECIAL_CASED_SCANS
(pyarrow/pandas/geopandas/polars) return a DataFrame without calling
_ensure_aliased(). This means many common DataFrame creations will still end up
with the anonymous/default qualifier (the original motivation for #926), so
joins may remain ambiguous for these inputs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
