jiayuasu commented on PR #3043: URL: https://github.com/apache/sedona/pull/3043#issuecomment-4685222624
One thing to fix before merge: `ST_3DDWithin` guards the spatial arguments, but not the nullable `distance` argument. Both overloads accept `Double` and then pass it to `org.apache.sedona.common.Predicates.dWithin3D(..., double)`, so `ST_3DDWithin(..., CAST(NULL AS DOUBLE))` will autounbox and throw instead of returning SQL `NULL`. Please add `distance == null` to both null guards and cover the null-distance case in `PredicateTest`. I verified the current focused test suite passes with: ```bash mvn -pl flink -Dtest=PredicateTest test ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
