paleolimbot commented on code in PR #989:
URL: https://github.com/apache/sedona-db/pull/989#discussion_r3453286435
##########
python/sedonadb/tests/functions/test_functions.py:
##########
@@ -3772,23 +3772,23 @@ def test_st_numinteriorrings_basic(eng, geom, expected):
("geom", "expected"),
[
(None, None),
- ("POINT EMPTY", None),
+ ("POINT EMPTY", 0),
("LINESTRING EMPTY", 0),
- ("POLYGON EMPTY", None),
- ("MULTIPOINT EMPTY", None),
- ("MULTILINESTRING EMPTY", None),
- ("MULTIPOLYGON EMPTY", None),
Review Comment:
Sorry to bikeshed here, but can we just remove this test and add a second
line to the ST_NPoints test? That will ensure that the behaviour stays in sync
and any added parameters always apply to both.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
