paleolimbot commented on code in PR #990:
URL: https://github.com/apache/sedona-db/pull/990#discussion_r3489021267
##########
python/sedonadb/tests/functions/test_functions.py:
##########
@@ -750,6 +750,59 @@ def test_st_buffer_style_parameters(
)
[email protected]("eng", [SedonaDB, PostGIS])
[email protected](
+ ("geom", "expected"),
+ [
+ (None, None),
+ ("LINESTRING (0 0, 1 0, 1 1, 0 0)", "POLYGON ((0 0, 1 1, 1 0, 0 0))"),
+ (
+ "MULTILINESTRING ((0 0, 1 0, 1 1, 0 0), (2 2, 3 2, 3 3, 2 2))",
+ "MULTIPOLYGON (((1 1, 1 0, 0 0, 1 1)), ((3 3, 3 2, 2 2, 3 3)))",
+ ),
+ ],
+)
+def test_st_buildarea(eng, geom, expected):
+ eng = eng.create_or_skip()
+ eng.assert_query_result(f"SELECT ST_BuildArea({geom_or_null(geom)})",
expected)
+
+
[email protected]("eng", [SedonaDB, PostGIS])
[email protected](
+ ("geom", "sedona_expected", "postgis_expected"),
+ [
+ # Both engines return an empty geometry for empty linework, not NULL.
+ # SedonaDB returns GEOMETRYCOLLECTION EMPTY; PostGIS returns POLYGON
EMPTY.
+ ("LINESTRING EMPTY", "GEOMETRYCOLLECTION EMPTY", "POLYGON EMPTY"),
+ ("MULTILINESTRING EMPTY", "GEOMETRYCOLLECTION EMPTY", "POLYGON EMPTY"),
+ ],
+)
+def test_st_buildarea_empty_linework(eng, geom, sedona_expected,
postgis_expected):
Review Comment:
Bumping this comment
##########
python/sedonadb/tests/functions/test_functions.py:
##########
@@ -1421,6 +1474,88 @@ def test_st_dump(eng):
assert actual["geom"] == shapely.from_wkt(expected["geom"]).wkb
[email protected]("eng", [SedonaDB, PostGIS])
[email protected](
+ ("geom", "expected"),
+ [
+ (None, None),
+ ("LINESTRING EMPTY", "GEOMETRYCOLLECTION EMPTY"),
+ ("POLYGON EMPTY", "GEOMETRYCOLLECTION EMPTY"),
+ (
+ "LINESTRING (0 0, 1 0, 0.5 1)",
+ "GEOMETRYCOLLECTION (POLYGON ((0.5 1, 0 0, 1 0, 0.5 1)))",
+ ),
+ (
+ "POLYGON ((0 0, 1 0, 0.5 1, 0 0))",
+ "GEOMETRYCOLLECTION (POLYGON ((0.5 1, 0 0, 1 0, 0.5 1)))",
+ ),
+ (
+ "MULTIPOINT ((0 0), (1 0), (0.5 1))",
+ "GEOMETRYCOLLECTION (POLYGON ((0.5 1, 0 0, 1 0, 0.5 1)))",
+ ),
+ ],
+)
+def test_st_delaunaytriangles(eng, geom, expected):
+ eng = eng.create_or_skip()
+ eng.assert_query_result(
+ f"SELECT ST_DelaunayTriangles({geom_or_null(geom)})", expected
+ )
+
+
[email protected]("eng", [SedonaDB, PostGIS])
[email protected](
+ ("geom", "tolerance", "expected"),
+ [
+ (None, None, None),
+ (
+ "MULTIPOINT ((0 0), (1 0), (0.5 1))",
+ 0.0,
+ "GEOMETRYCOLLECTION (POLYGON ((0.5 1, 0 0, 1 0, 0.5 1)))",
+ ),
+ (
+ "MULTIPOINT ((0 0), (0.001 0), (1 0), (0.5 1))",
+ 1.0,
+ "GEOMETRYCOLLECTION (POLYGON ((0.5 1, 0 0, 1 0, 0.5 1)))",
+ ),
+ ],
+)
+def test_st_delaunaytriangles_tolerance(eng, geom, tolerance, expected):
+ eng = eng.create_or_skip()
+ if tolerance is None:
+ eng.assert_query_result(
+ f"SELECT ST_DelaunayTriangles({geom_or_null(geom)}, NULL)",
expected
+ )
+ else:
+ eng.assert_query_result(
+ f"SELECT ST_DelaunayTriangles({geom_or_null(geom)}, {tolerance})",
expected
+ )
Review Comment:
Is there any objection to using the `val_or_null()` helper here?
##########
python/sedonadb/tests/functions/test_functions.py:
##########
@@ -750,6 +750,59 @@ def test_st_buffer_style_parameters(
)
[email protected]("eng", [SedonaDB, PostGIS])
[email protected](
+ ("geom", "expected"),
+ [
+ (None, None),
+ ("LINESTRING (0 0, 1 0, 1 1, 0 0)", "POLYGON ((0 0, 1 1, 1 0, 0 0))"),
+ (
+ "MULTILINESTRING ((0 0, 1 0, 1 1, 0 0), (2 2, 3 2, 3 3, 2 2))",
+ "MULTIPOLYGON (((1 1, 1 0, 0 0, 1 1)), ((3 3, 3 2, 2 2, 3 3)))",
+ ),
+ ],
+)
+def test_st_buildarea(eng, geom, expected):
+ eng = eng.create_or_skip()
+ eng.assert_query_result(f"SELECT ST_BuildArea({geom_or_null(geom)})",
expected)
+
+
[email protected]("eng", [SedonaDB, PostGIS])
[email protected](
+ ("geom", "sedona_expected", "postgis_expected"),
+ [
+ # Both engines return an empty geometry for empty linework, not NULL.
+ # SedonaDB returns GEOMETRYCOLLECTION EMPTY; PostGIS returns POLYGON
EMPTY.
+ ("LINESTRING EMPTY", "GEOMETRYCOLLECTION EMPTY", "POLYGON EMPTY"),
+ ("MULTILINESTRING EMPTY", "GEOMETRYCOLLECTION EMPTY", "POLYGON EMPTY"),
+ ],
+)
+def test_st_buildarea_empty_linework(eng, geom, sedona_expected,
postgis_expected):
+ is_postgis = eng is PostGIS
+ eng = eng.create_or_skip()
+ expected = postgis_expected if is_postgis else sedona_expected
+ eng.assert_query_result(f"SELECT ST_BuildArea({geom_or_null(geom)})",
expected)
+
+
[email protected]("eng", [SedonaDB, PostGIS])
[email protected](
+ ("geom", "sedona_expected", "postgis_expected"),
+ [
+ ("POINT (0 0)", None, None),
Review Comment:
Bumping this comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
