Copilot commented on code in PR #1017:
URL: https://github.com/apache/sedona-db/pull/1017#discussion_r3494688442
##########
python/sedonadb/src/error.rs:
##########
@@ -68,3 +69,9 @@ impl From<ArrowError> for PySedonaError {
PySedonaError::DF(Box::new(DataFusionError::ArrowError(Box::new(other), None)))
}
}
+
+impl From<PyClassGuardError<'_, '_>> for PySedonaError {
+ fn from(other: PyClassGuardError) -> Self {
+ PySedonaError::SedonaPython(other.to_string())
+ }
+}
Review Comment:
`PyClassGuardError` has lifetime parameters in the `From` impl
(`PyClassGuardError<'_, '_>`), but the `from` method parameter omits them. This
won’t compile because the method signature must match the `From<T>` type
exactly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
