jiayuasu commented on PR #120: URL: https://github.com/apache/sedona-spatialbench/pull/120#issuecomment-4911554531
Thanks for adding PyCanopy support. I found a couple of issues that should be fixed before merging. 1. `spatialbench-queries/pycanopy_queries.py`: Q9 does not return the canonical result schema. The benchmark query returns `building_1`, `building_2`, `area1`, `area2`, `overlap_area`, and `iou`, but the PyCanopy implementation only returns `building_1`, `building_2`, and `iou`. Even though the harness mostly records timing and row counts, these per-engine query implementations should preserve the documented query output shape. 2. `spatialbench-queries/pycanopy_queries.py`: Q12 also returns a different schema from the benchmark query. The canonical Q12 output includes `t_tripkey`, `t_pickuploc`, `b_buildingkey`, `building_name`, and `distance_to_building`; the PyCanopy version currently returns only `t_tripkey`, `b_buildingkey`, and `distance_to_polygon`. Please include the missing fields and use the canonical distance column name so this adapter is actually running the same benchmark contract as the other engines. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
