paleolimbot commented on code in PR #1042:
URL: https://github.com/apache/sedona-db/pull/1042#discussion_r3548641968
##########
python/sedonadb/tests/functions/test_predicates.py:
##########
@@ -45,6 +45,11 @@
"GEOMETRYCOLLECTION (POINT (0 0), POLYGON ((0 0, 1 0, 1 1, 0 1, 0
0)), LINESTRING (0 0, 1 1))",
False,
),
+ (
+ "GEOMETRYCOLLECTION (POINT (0 0), LINESTRING (0 0, 0 1))",
+ "POINT (0 0)",
+ False,
+ ),
Review Comment:
Can you add some more related cases here to make sure we correctly figured
this one out? I am not sure about all of these but we should probably match
PostGIS here. When confirmed, these can go in Rust as well.
```suggestion
(
"GEOMETRYCOLLECTION (POINT (0 0))",
"POINT (0 0)",
True,
),
(
"GEOMETRYCOLLECTION (POINT (0 0), LINESTRING (0 0, 0 1))",
"POINT (0 0)",
False,
),
# True because the point is no longer on the boundary
(
"GEOMETRYCOLLECTION (POINT (0 0), LINESTRING (0 0, 0 1))",
"POINT (0 0.5)",
True,
),
# True because the point is no longer on the boundary
(
"GEOMETRYCOLLECTION (POINT (-1 -1), LINESTRING (0 0, 0 1))",
"POINT (-1 -1)",
True,
),
(
"GEOMETRYCOLLECTION (POINT (0 0), POLYGON ((0 0, 0 1, 1 0, 0
0)))",
"POINT (0 0)",
False,
),
(
"GEOMETRYCOLLECTION (POINT (0 0), POLYGON ((0 0, 0 1, 1 0, 0
0)))",
"POINT (0.25 0.25)",
True,
),
(
"GEOMETRYCOLLECTION (LINESTRING (0 0, 0 1), POLYGON ((0 0, 0 1,
1 0, 0 0)))",
"LINESTRING (0 0, 0 1)",
False,
),
(
"GEOMETRYCOLLECTION (LINESTRING (0 0, 0 1), POLYGON ((0 0, 0 1,
1 0, 0 0)))",
"LINESTRING (0 0, 0.25 0.25)",
True,
),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
