jiayuasu commented on PR #3102: URL: https://github.com/apache/sedona/pull/3102#issuecomment-4964975050
Fixed the CI failures in `CrsRoundTripComplianceTest` (all 7 were in that one raster CRS round-trip test; the vector transform path and the new EPSG:5880 case are green). They fell into two groups: **Capability gains (fixed here).** `testExportFails_Krovak_2065` and `testExportFails_HotineObliqueMercator_2056` asserted these projections were *unsupported* by proj4sedona (export must fail). 0.1.0 adds Krovak variants and Hotine Oblique Mercator PROJ-string serialization, so both now export and round-trip stably — the negative tests are converted to positive `assertProjRoundTrip` checks (and the now-unused `assertExportFails` helper removed). **Raster CRS-bridge path divergence (tracked separately).** Five PROJ-format round trips (EPSG:5070, 3577, 27700, 28992, 3111) are no longer byte-idempotent, because Sedona's raster CRS bridge exports a CRS differently depending on whether it arrived as a `+datum=` code or a `+towgs84=`/raw PROJ string — a pre-existing inconsistency that 0.0.8's coarser output masked and 0.1.0's more PROJ-correct serialization exposed. **Transforms are unaffected** (this is byte-stability of the exported CRS *string*), and the PROJJSON/WKT1/WKT2 round trips for the same CRSs still pass. Marked `@Ignore` referencing #3103, which has the full diagnosis and repro. `CrsRoundTripComplianceTest` now runs 81 / 0 failures / 5 skipped locally; spotless and the pre-commit hooks pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
