paleolimbot commented on code in PR #1049:
URL: https://github.com/apache/sedona-db/pull/1049#discussion_r3576080120
##########
rust/sedona-raster-functions/src/rs_georeference.rs:
##########
@@ -201,9 +186,10 @@ fn format_georeference(
)
}
GeoReferenceFormat::Esri => {
- format.reject_skew(skew_x, skew_y)?;
- let esri_upper_left_x = upper_left_x + scale_x * 0.5;
- let esri_upper_left_y = upper_left_y + scale_y * 0.5;
+ // World coordinates of pixel-space (0.5, 0.5) — the full
+ // affine keeps the center shift exact under skew.
+ let esri_upper_left_x = upper_left_x + (scale_x + skew_x)
* 0.5;
+ let esri_upper_left_y = upper_left_y + (skew_y + scale_y)
* 0.5;
Review Comment:
Should we use one of the helper functions for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
