jiayuasu commented on PR #1044: URL: https://github.com/apache/sedona-db/pull/1044#issuecomment-4977233210
Went with the error approach (option 3). Added `write_sedona_csv`/`write_sedona_json` to the `SedonaDataFrame` trait so the guard lives in Rust and R can reuse it. A geometry/geography column — including one nested inside a struct/list (e.g. `ST_Dump` output) — now errors with a message pointing at the text projection, rather than silently writing hex WKB: ``` Cannot write geometry column(s) ["geometry"] to CSV: this format has no geometry representation. Convert them to text first (e.g. SELECT ST_AsText(geom) AS geom) before writing. ``` Same guard for LDJSON. I left the WKT-as-*default* (wrapping the CSV/JSON `FileFormat`) for the `FileFormatFactory` work as you suggested — this PR just stops the surprising hex-WKB default. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
