prantogg commented on code in PR #124: URL: https://github.com/apache/sedona-spatialbench/pull/124#discussion_r3605848735
########## docs/index.md: ########## @@ -81,7 +81,8 @@ FROM trip t JOIN building b ON ST_DWithin(t.t_pickup_loc, b.b_boundary, 500) GROUP BY b.b_buildingkey, b.b_name -ORDER BY nearby_pickup_count DESC; +ORDER BY nearby_pickup_count DESC Review Comment: Is this meant to be similar to Q8? If so, its missing `b_buildingkey ASC` that [queries.md](https://github.com/apache/sedona-spatialbench/pull/124/changes#diff-8059313f9d33353a477bae8a0a24e7ab1c90ee498e8681a7f05ae7d85966906cL400) has to make it deterministic. ########## docs/queries.md: ########## @@ -259,20 +260,13 @@ JOIN customer c ON t.t_custkey = c.c_custkey GROUP BY c.c_custkey, c.c_name, pickup_month HAVING dropoff_count > 5 -- Only include repeat customers -ORDER BY monthly_travel_hull_area DESC, c.c_custkey ASC +ORDER BY dropoff_count DESC, c.c_custkey ASC, pickup_month ASC Review Comment: A sufficiently smart optimizer could compute counts only, pick the top 100, and evaluate the convex hull for just those 100. This would be like quick top-k instead of doing full work. I think just adding a LIMIT 100 would give us the bounded result without changing the query? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
