james-willis commented on code in PR #1056:
URL: https://github.com/apache/sedona-db/pull/1056#discussion_r3605900400
##########
rust/sedona-raster-functions/src/rs_setsrid.rs:
##########
@@ -395,9 +395,33 @@ mod tests {
use sedona_raster::traits::RasterRef;
use sedona_schema::crs::deserialize_crs;
use sedona_schema::datatypes::RASTER;
+ use sedona_testing::raster_spec::{assert_rasters_equal, RasterSpec};
use sedona_testing::rasters::generate_test_rasters;
use sedona_testing::testers::ScalarUdfTester;
+ /// The non-null raster that [`generate_test_rasters`] produces at index
+ /// `i`, expressed as a declarative spec: the same per-index geotransform
+ /// arithmetic and sequential UInt16 pixels with nodata 0. Used as the
+ /// expected side after an RS_SetSRID/RS_SetCRS, which only swaps the CRS
+ /// and preserves everything else — so callers append `.crs(...)` with the
+ /// CRS they expect.
+ fn generated_raster_spec(i: usize) -> RasterSpec {
Review Comment:
the RasterSpec is different than a Raster, its used to assert the interface
of a raster is what is expected.
Migrated this to a util in sedona-testing so we can reuse it with
generate_test_rasters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
