jiayuasu commented on code in PR #2466: URL: https://github.com/apache/sedona/pull/2466#discussion_r3612176477
########## python/sedona/spark/geopandas/geodataframe.py: ########## Review Comment: Neutralized the inherited geodataframe.py and geoseries.py changes. These files now have no net diff from the current base branch. ########## python/tests/geopandas/test_sjoin_match.py: ########## @@ -0,0 +1,43 @@ +import pytest +import geopandas as gpd +from shapely.geometry import Point +from sedona.geopandas import sjoin Review Comment: Rebuilt the test with the current import and actual Sedona GeoDataFrame inputs. It now compares normalized Sedona and GeoPandas results for distances producing 0, 2, and 3 matches, plus left-join unmatched-row behavior. The focused file passes locally with four tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
