jiayuasu commented on code in PR #127:
URL: 
https://github.com/apache/sedona-spatialbench/pull/127#discussion_r3634638907


##########
benchmark/answers/README.md:
##########
@@ -0,0 +1,58 @@
+# SpatialBench ground-truth answers
+
+Reference results for the SpatialBench queries, used by the correctness 
harness to
+verify that every participating engine returns the same answer for the same 
query.
+
+## Layout
+
+```
+answers/
+  sf1/q1.parquet  q1.csv  ...  q12.parquet  q12.csv     # scale factor 1  
(SF10 to follow)
+```

Review Comment:
   Fixed in e1c12b6 — the layout now shows the real 
`benchmark/answers/sf1/q{1..12}.{parquet,csv}` paths instead of the ambiguous 
`answers/` tree.



##########
README.md:
##########
@@ -59,6 +59,10 @@ The automated tests cover:
 - 🐻‍❄️ **Spatial Polars** - Geospatial extension for Polars dataframes
 - 🌴 **PyCanopy** - High-performance spatial query engine for Polars
 
+### Verifying correctness
+
+SpatialBench ships reference answers for every query under 
[`benchmark/answers/`](benchmark/answers/) (currently scale factor 1). They are 
the output of the canonical SedonaDB dialect, independently cross-checked 
against DuckDB, and let you confirm that each engine returns the same result 
for the same query — not just that it runs. See the [answers 
README](benchmark/answers/README.md) for the format and comparison rules.

Review Comment:
   Fixed in e1c12b6 — qualified the claim to "cross-checked against DuckDB for 
every query DuckDB can compute at this scale (all except Q12, whose 
lateral-join plan is infeasible at SF1)", matching the caveat in the answers 
README.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to