james-willis commented on code in PR #3114: URL: https://github.com/apache/sedona/pull/3114#discussion_r3634702382
########## docs/api/sql/Raster-Operators/RS_AsRaster.md: ########## @@ -26,7 +26,7 @@ Introduction: `RS_AsRaster` converts a vector geometry into a raster dataset by * `pixelType`: Defines data type of the output raster. This can be one of the following, D (double), F (float), I (integer), S (short), US (unsigned short) or B (byte). * `allTouched` (Since: `v1.7.1`): Decides the pixel selection criteria. If set to `true`, the function selects all pixels touched by the geometry, else, selects only pixels whose centroids intersect the geometry. Defaults to `false`. * `value`: The value to be used for assigning pixels covered by the geometry. Defaults to using `1.0` if not provided. -* `noDataValue`: Used for assigning the no data value of the resultant raster. Defaults to `null` if not provided. +* `noDataValue`: Used for assigning the no data value of the resultant raster; pixels not covered by the geometry are set to this value. Defaults to `null` if not provided, in which case uncovered pixels are `0` and the raster has no no data value. Review Comment: This approach matches what Postgis but does I wonder if we should just provide a different parameter for the background value that is not coupled to the no data value. Theres no reason that the background has to be the NDV and it more cleanly solves some of the question in this thread. Imo the only downside to this is that it deviates from postgis -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
