paleolimbot commented on PR #1070: URL: https://github.com/apache/sedona-db/pull/1070#issuecomment-5053132726
It's great sentiment...keep track of the differences between engines programmatically using the tools pytest gives us. I also know you're using these to fix inconsistencies and bugs and that's great. I think it just needs to be moved outside python/sedonadb and its own CI workflow that doesn't run for changes in the python/ files. (I probably should have done this a while ago with the vector integration tests too, not specific to your code). Separate from that, there is enough indirection in the testing method here that it's hard to know what is being tested by reading the test. I tried to keep the vector testing framework limited to comparing values so that the tests themselves are hopefully clear about what they do without reading the test harness. Fixtures, test helper functions, and xfails are all indirection. Some is OK, too much and nobody knows what the tests are doing. Syntax alignment I also think is a future consideration. When this works and is fast and doesn't run out of memory would be a great time to align syntax. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
