james-willis opened a new issue, #1082: URL: https://github.com/apache/sedona-db/issues/1082
`RS_Intersects`/`RS_Contains`/`RS_Within` and the raster–vector spatial join now route CRS reprojection through the `SedonaOptions`-injected `CrsEngine` (via `crs_utils::with_crs_engine` / an `invoke_batch_from_args` override, mirroring `RS_Clip`) — landed in #1073. The remaining production uses of the process-global `with_global_proj_engine` are the geometry functions in `c/sedona-proj`: - `ST_Transform` (`c/sedona-proj/src/st_transform.rs`) - `sd_order` (`c/sedona-proj/src/sd_order_lnglat.rs`) These can't reuse `crs_utils::with_crs_engine` because that helper lives in `sedona-raster-functions`, which is above `sedona-proj` in the crate graph. Routing them through the injected engine needs a **lower-crate helper**: move the `SedonaOptions` → `runtime.crs_engine()` extraction (with the config-less fallback to `LazyProjEngine`) down into `sedona-common` or `sedona-proj` so `sedona-proj` functions can call it. Notes: - `ST_Transform` already has `config_options` plumbed through `invoke_batch_from_args` (currently ignored) — it just needs to route through the lower-crate helper. - `sd_order` has no `invoke_batch_from_args` override yet — one needs adding. - Behavior-neutral in the common case (the injected engine defaults to `LazyProjEngine`, which delegates to the global one). Done when `git grep with_global_proj_engine` shows only the definition in `sedona-proj`, `LazyProjEngine`'s internal delegation, and test-only uses. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
