jiayuasu opened a new pull request, #3173:
URL: https://github.com/apache/sedona/pull/3173

   ## Did you read the Contributor Guide?
   
   - Yes, I have read the [Contributor 
Rules](https://sedona.apache.org/latest/community/rule/) and [Contributor 
Development Guide](https://sedona.apache.org/latest/community/develop/)
   
   ## Is this PR related to a ticket?
   
   - Yes, and the PR name follows the format `[GH-XXX] my subject`.
   
   Closes #3171.
   Closes #3172.
   
   ## What changes were proposed in this PR?
   
   - Treat empty `Polygon` and `MultiPolygon` inputs as vacuously true in both 
`ST_IsPolygonCW` and `ST_IsPolygonCCW`.
   - Avoid accessing the first component of an empty `MultiPolygon`, and treat 
empty members of mixed multipolygons as neutral.
   - Add common, Spark, Flink, and Snowflake coverage and document the 
empty-geometry behavior across all three engines.
   - Accept Python and NumPy integer values for 
`GeoSeries.skew(use_radians=...)`, matching GeoPandas truthiness behavior while 
retaining strict rejection of non-integral values.
   
   The orientation predicates previously accessed `getGeometryN(0)` 
unconditionally for multipolygons and did not handle an empty polygon 
consistently. The GeoSeries method separately restricted `use_radians` to 
boolean scalar types even though GeoPandas also accepts integer boolean-like 
values.
   
   ## How was this patch tested?
   
   - `mvn -pl common -Dtest=FunctionsTest test` (302 tests)
   - Spark `functionTestScala` suite (235 tests)
   - Focused Flink empty-polygon orientation test
   - `python -m pytest -q tests/geopandas/test_geoseries.py -k skew` (20 tests)
   - `mvn -Dsnowflake=true -pl snowflake-tester -am -DskipTests package`
   - Repository pre-commit hooks
   
   ## Did this PR include necessary documentation updates?
   
   - Yes, I have updated the documentation.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to