jiayuasu commented on code in PR #3211:
URL: https://github.com/apache/sedona/pull/3211#discussion_r3714873330
##########
flink/src/main/java/org/apache/sedona/flink/expressions/Aggregators.java:
##########
@@ -391,7 +392,10 @@ public void resetAccumulator(Accumulators.AccGeometry acc)
{
rawSerializer = GeometryTypeSerializer.class,
bridgedTo = Geometry.class),
accumulator =
- @DataTypeHint(value = "RAW", bridgedTo =
Accumulators.AccGeometryCollection.class),
+ @DataTypeHint(
+ value = "RAW",
+ rawSerializer = AccGeometryCollectionTypeSerializer.class,
Review Comment:
`ST_Collect_Agg` is already in `sedona-1.9.1-rc1` with the old bare `RAW`
accumulator. If 1.9.1 final ships that format, state from its
checkpoints/savepoints will not restore with this serializer in 2.0.0. Could we
backport this serializer to the 1.9.1 release for RC2? If not, please add the
same restore-compatibility warning to the 2.0.0 release notes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
