jbampton opened a new issue, #3240:
URL: https://github.com/apache/sedona/issues/3240
## Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated
no new comments.
<details>
<summary>Suppressed comments (3)</summary>
**Makefile:68**
* `make update-deps` invokes `prek` directly (and then suppresses failures).
If `prek` is only installed inside the uv-managed environment, this will be a
no-op on fresh setups. Run it via `uv run` to ensure the hook update actually
executes against the locked environment.
```
update-deps: check-install ## Update pre-commit hooks and dependency locks
prek auto-update --freeze || :
uv lock --upgrade
```
**Makefile:64**
* `make update` invokes `prek` directly. Since `prek` is declared as a dev
dependency (installed into `.venv` by `uv sync`) and the docs describe
uv-managed execution, this target will fail unless `prek` is already available
on the user's PATH. Prefer running it through `uv run` so it uses the
project-managed environment.
This issue also appears on line 66 of the same file.
```
update: install
prek auto-update --freeze
```
**docs/setup/compile.md:192**
* This paragraph states that the Makefile+uv workflow guarantees `prek` runs
in the locked environment, but the current Makefile targets invoke `prek`
directly (not via `uv run`). Either update the Makefile to use `uv run prek
...` consistently, or soften this wording to avoid implying the environment is
guaranteed.
```
The `Makefile` handles environment isolation and dependency resolution
automatically using `uv`. For maximum convenience, you should interact with
`prek` entirely through the following make shortcuts:
```
</details>
_Originally posted by @Copilot in
https://github.com/apache/sedona/pull/3081#pullrequestreview-4838329446_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
