jiayuasu opened a new pull request, #3242: URL: https://github.com/apache/sedona/pull/3242
## Did you read the Contributor Guide? - Yes, I have read the [Contributor Rules](https://sedona.apache.org/latest/community/rule/) and [Contributor Development Guide](https://sedona.apache.org/latest/community/develop/) ## Is this PR related to a ticket? - No: this is a CI update. The PR name follows the format `[CI] my subject`. ## What changes were proposed in this PR? Remove the `POLYGON EMPTY` / `MULTIPOLYGON EMPTY` assertions from `TestFunctionsV2.test_ST_IsPolygonCW` and `test_ST_IsPolygonCCW` in the Snowflake tester, added in #3173. These assertions can never pass against real Snowflake: the inner `ST_GeomFromWKT` in the V2 tests is Snowflake's built-in WKT parser, and Snowflake's native GEOMETRY type parses empty geometries to NULL. Since Sedona UDFs are registered with `RETURNS NULL ON NULL INPUT`, `sedona.ST_IsPolygonCW(NULL)` returns NULL instead of `true`: ``` TestFunctionsV2.test_ST_IsPolygonCW:1214 expected:<true> but was:<null> TestFunctionsV2.test_ST_IsPolygonCCW:1247 expected:<true> but was:<null> ``` Empty-geometry behavior of `ST_IsPolygonCW`/`ST_IsPolygonCCW` remains covered by the WKB-based tests in `TestFunctions`, where geometry serialization stays fully in Sedona's control. ## How was this patch tested? Verified against a real Snowflake environment in wherobots/sedona-cloud-vendor-tester#72: the full Snowflake integration suite passed with this change ([run](https://github.com/wherobots/sedona-cloud-vendor-tester/actions/runs/31079432797), 383 tests, 0 failures), where master previously failed the two assertions above ([failing run](https://github.com/wherobots/sedona-cloud-vendor-tester/actions/runs/31069974789)). ## Did this PR include necessary documentation updates? - No, this PR does not affect any public API so no need to change the documentation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
